#1 2018-08-01 04:24:14

backamunga
Member
Registered: 2018-07-03
Posts: 6

Make units clearer on email report

Suggested patch to xsibackup (original md5sum b467ca74bca0ad8bb356eca591a94705):

@@ -3616,14 +3616,14 @@
 	fi
 
 	vmlistHTMLStr=$vmlistHTMLStr"<tr>\r\n
-<td><b>(Id)VM Name</b></td>\r\n
+<td><b>(Id) VM Name</b></td>\r\n
 <td><b>State</b></td>\r\n
-<td><b>Size (Gb)</b></td>\r\n
+<td><b>Size (GB)</b></td>\r\n
 <td><b>Stop</b></td>\r\n
 <td><b>Copy</b></td>\r\n
 <td><b>Start</b></td>\r\n
 <td><b>Time (min)</b></td>\r\n
-<td><b>Speed (mb/s)</b></td>\r\n
+<td><b>Speed (MB/s)</b></td>\r\n
 </tr>\r\n"
 	
 fi

For a while (longer than I care to admit) I thought "mb/s" was megabits/second....

Offline

#2 2018-08-01 08:14:15

admin
Administrator
Registered: 2017-04-21
Posts: 1,363

Re: Make units clearer on email report

Megabits per second are expressed as MBPS

Offline

#3 2018-08-02 00:50:34

backamunga
Member
Registered: 2018-07-03
Posts: 6

Re: Make units clearer on email report

Hello,

I believe a cursory Google search will reveal that a 'b' typically refers to bits and a 'B' refers to bytes, or at the very least, will support the reasonableness of my initial interpretation.

Nonetheless, I'm not here to argue the semantics or nuances of capitalization of acronyms.  I'm simply suggesting a minor code change that I think will be an improvement.  Feel free to take it or leave it; I've already updated my copy of the code.

Thanks for the consideration.

Offline

Board footer